[PATCH] D89025: [RISCV] Add -mtune support

This revision was automatically updated to reflect the committed changes. Closed by commit rGcfa7094e49cf: [RISCV] Add -mtune support (authored by Kito Cheng kito.ch...@sifive.com). Herald added a subscriber: NickHung. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89025: [RISCV] Add -mtune support

kito-cheng marked an inline comment as done. kito-cheng added a comment. @MaskRay Thanks, that's first time I know the suffix `-SAME` :P CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89025/new/ https://reviews.llvm.org/D89025 ___

[PATCH] D89025: [RISCV] Add -mtune support

kito-cheng updated this revision to Diff 298293. kito-cheng added a comment. ChangeLog: - Update testcase according to MaskRay's suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89025/new/ https://reviews.llvm.org/D89025 Files: clang/include/clang/Driver/Options.td

[PATCH] D89025: [RISCV] Add -mtune support

MaskRay added inline comments. Comment at: clang/test/Driver/riscv-cpus.c:91 +// MTUNE-E31-MCPU-E76: "-target-feature" "+a" +// MTUNE-E31-MCPU-E76-NOT: "-target-feature" "+f" +// MTUNE-E31-MCPU-E76: "-target-feature" "+c" A NOT pattern depends on the feature

[PATCH] D89025: [RISCV] Add -mtune support

kito-cheng marked 3 inline comments as done. kito-cheng added a comment. In D89025#2327749 , @luismarques wrote: > In D89025#2324334 , @khchen wrote: > >> RISCV supports `-mcpu` with default empty arch to align

[PATCH] D89025: [RISCV] Add -mtune support

kito-cheng updated this revision to Diff 298060. kito-cheng added a comment. ChangeLog - Fix wording in comment - Add more comment in testcase - Fix format issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89025/new/ https://reviews.llvm.org/D89025 Files:

[PATCH] D89025: [RISCV] Add -mtune support

kito-cheng added a comment. > If possible that would good, since -mcpu is deprecated (for e.g. x86_64) or > unsupported in GCC (for e.g. RISC-V). So doing that would further align Clang > with GCC. But I wonder if this might be too problematic, in terms of > compatibility. I am also working

[PATCH] D89025: [RISCV] Add -mtune support

luismarques added a comment. In D89025#2324334 , @khchen wrote: > RISCV supports `-mcpu` with default empty arch to align gcc's `-mtune` > behavior since clang didn't support `-mtune` before. But now clang has > `-mtune`, is it a good idea to remove

[PATCH] D89025: [RISCV] Add -mtune support

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. LGTM, but I would like other people to also review this, if possible. (Just be sure to check/fix the clang-format warnings and the inline comments). Comment at:

[PATCH] D89025: [RISCV] Add -mtune support

khchen added a comment. RISCV supports `-mcpu` with default empty arch to align gcc's `-mtune` behavior since clang didn't support `-mtune` before. But now clang has `-mtune`, is it a good idea to remove those options? (ex. `rocket-rv32/rv64`, `sifive-7-rv32/64`) Comment at:

[PATCH] D89025: [RISCV] Add -mtune support

kito-cheng created this revision. kito-cheng added reviewers: asb, evandro, lenary, khchen. kito-cheng added projects: LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, dang, luismarques, apazos, sameer.abuasal, pzheng, pengfei, s.egerton, Jim, benna, psnobl, jocewei, PkmX,