[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

martong added a comment. Unfortunately, I could not reproduce the mentioned crash on our macOS machine. The mentioned test just passed with the output below. I gave up. myuser@msmarple ~/llvm3/build/release_assert $ /usr/local/Frameworks/Python.framework/Versions/3.8/bin/python3.8

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

martong added a comment. Ups, sorry for the break and thanks for the notice! I am going to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89318/new/ https://reviews.llvm.org/D89318 ___

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

kastiglione added a comment. Reverted here: 4cb4db11ee1323c5d4bf66d21deb046970f4e516 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89318/new/ https://reviews.llvm.org/D89318

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

kastiglione added a comment. @martong here's a partial backtrace: 3: LLDB`llvm::llvm_unreachable_internal(char const*, char const*, unsigned int) 4: LLDB`clang::AttributeCommonInfo::calculateAttributeSpellingListIndex() const 5: LLDB`clang::ASTImporter::Import(clang::Attr const*) 6:

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

kastiglione added a comment. @martong hi, this caused a test regression. In `TestImportBuiltinFileID.py`, this unreachable assertion is hit: Ignored/unknown shouldn't get here UNREACHABLE executed at tools/clang/include/clang/Sema/AttrSpellingListIndex.inc:13! See

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG73c6beb2f705: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex (authored by martong).

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

martong marked an inline comment as done. martong added a comment. Thanks for the reivew! Comment at: clang/lib/AST/ASTImporter.cpp:8109 + FromAttr->getAttributeSpellingListIndex()); + ToAttr->setPackExpansion(FromAttr->isPackExpansion()); +

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/ASTImporter.cpp:8109 + FromAttr->getAttributeSpellingListIndex()); + ToAttr->setPackExpansion(FromAttr->isPackExpansion()); +

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

martong created this revision. martong added reviewers: teemperor, shafik. Herald added subscribers: cfe-commits, pengfei, gamesh411, Szelethus, arphaman, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. martong requested review of this revision. During the