This revision was automatically updated to reflect the committed changes.
Closed by commit rG65cb4fdd69f4: [libTooling] Change `after` range-selector to
operate only on source ranges (authored by ymandel).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ymandel added inline comments.
Comment at: clang/unittests/Tooling/RangeSelectorTest.cpp:196
+static void testAfterMacroArg(StringRef Code) {
+ const std::string Ref = "ref";
tdl-g wrote:
> If this helper function took an "expected" parameter I might consider
ymandel updated this revision to Diff 298392.
ymandel added a comment.
cleaned up test code
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89468/new/
https://reviews.llvm.org/D89468
Files:
clang/lib/Tooling/Transformer/RangeSelector.cpp
tdl-g requested changes to this revision.
tdl-g added a comment.
This revision now requires changes to proceed.
Just one comment about the tests.
Comment at: clang/unittests/Tooling/RangeSelectorTest.cpp:196
+static void testAfterMacroArg(StringRef Code) {
+ const
ymandel created this revision.
ymandel added a reviewer: tdl-g.
Herald added a project: clang.
ymandel requested review of this revision.
Currently, `after` fails when applied to locations in macro arguments. This
change projects the subrange into a file source range and then applies `after`.
