Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

Yes, that's right. I think most errors are caught in Sema. There "if there is an error, the output should be suppressed" should be a consensus. For some auxiliary files it was a bit fuzzy to me. So I checked .dwo which is a similar auxiliary output - the output is suppressed with an error - so it b

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Nov 4, 2020 at 9:07 PM Fāng-ruì Sòng wrote: > > It is rare to report an error in BackendUtil.cpp . So I checked the > other Diags.Report instance and noticed that -split-dwarf-file a.dwo > -split-dwarf-output a.dwo (when a.dwo is not writable) suppresses the > output. So there is no reason

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

It is rare to report an error in BackendUtil.cpp . So I checked the other Diags.Report instance and noticed that -split-dwarf-file a.dwo -split-dwarf-output a.dwo (when a.dwo is not writable) suppresses the output. So there is no reason that -fbasic-block-sections=list= should not follow the conven

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Nov 4, 2020 at 8:08 PM Fāng-ruì Sòng wrote: > I checked chmod -w a.dwo; clang -cc1 -debug-info-kind=limited > -dwarf-version=4 -split-dwarf-file a.dwo -split-dwarf-output a.dwo > -emit-obj -o - split-debug-output.c > which suppresses the output, so -fbasic-block-sections=list= should > fo

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

I checked chmod -w a.dwo; clang -cc1 -debug-info-kind=limited -dwarf-version=4 -split-dwarf-file a.dwo -split-dwarf-output a.dwo -emit-obj -o - split-debug-output.c which suppresses the output, so -fbasic-block-sections=list= should follow the convention as well. Sent https://reviews.llvm.org/D908

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Tue, Oct 27, 2020 at 2:21 PM Sriraman Tallam via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Tue, Oct 27, 2020 at 2:14 PM David Blaikie via Phabricator < > revi...@reviews.llvm.org> wrote: > >> dblaikie added a comment. >> >> @tmsriram ping on the follow-up here >> > > I checked i

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Tue, Oct 27, 2020 at 2:14 PM David Blaikie via Phabricator < revi...@reviews.llvm.org> wrote: > dblaikie added a comment. > > @tmsriram ping on the follow-up here > I checked in the patch that emits llvm instead of obj which spews garbage to the terminal as I wasn't redirecting it to /dev/null

[PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

dblaikie added a comment. @tmsriram ping on the follow-up here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89500/new/ https://reviews.llvm.org/D89500 ___ cfe-commits mailing list cfe-commits@lists.llvm

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Oct 21, 2020 at 11:59 AM Sriraman Tallam wrote: > > On Wed, Oct 21, 2020 at 11:45 AM Sriraman Tallam wrote: > > > > On Wed, Oct 21, 2020 at 11:07 AM David Blaikie via Phabricator > > wrote: > > > > > > dblaikie added a comment. > > > > > > In D89500#2344234

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Oct 21, 2020 at 11:45 AM Sriraman Tallam wrote: > > On Wed, Oct 21, 2020 at 11:07 AM David Blaikie via Phabricator > wrote: > > > > dblaikie added a comment. > > > > In D89500#2344234 , @davezarzycki > > wrote: > > > > > I think I fixed it. Please

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Oct 21, 2020 at 11:07 AM David Blaikie via Phabricator wrote: > > dblaikie added a comment. > > In D89500#2344234 , @davezarzycki > wrote: > > > I think I fixed it. Please verify: 87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 > >

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Oct 21, 2020 at 11:07 AM David Blaikie via Phabricator wrote: > > dblaikie added a comment. > > In D89500#2344234 , @davezarzycki > wrote: > > > I think I fixed it. Please verify: 87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 > >

[PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

dblaikie added a comment. In D89500#2344234 , @davezarzycki wrote: > I think I fixed it. Please verify: 87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 > Thanks - if that's unblocked you, gr

[PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

davezarzycki added a comment. I think I fixed it. Please verify: 87f6de72bcd346bbbf468e9f9a0e9d1bbf0630a9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89500/new/ https://reviews.llvm.org/D89500 ___ cfe-

[PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

davezarzycki added a comment. A git bisect run blamed this patch for breaking the ability to build with a read-only source tree. Can we revert this or make a quick fix? FAIL: Clang :: CodeGen/basic-block-sections.c (3385 of 26774) TEST 'Clang :: CodeGen/basic-block-secti

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Tue, Oct 20, 2020 at 6:19 PM Nico Weber via Phabricator wrote: > > thakis added a comment. > > Looks like this breaks tests on windows: > http://45.33.8.238/win/26253/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Sorry I saw this message late. Looks like Fan

[PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/26253/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89500/new/ https://reviews.llv

[PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

This revision was automatically updated to reflect the committed changes. Closed by commit rGf88785460ecf: Improve file doesnt exist error with -fbasic-block-sections= (authored by tmsriram). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION