[PATCH] D89834: FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef

dexonsmith added a comment. In D89834#2356769 , @arphaman wrote: > What's wrong with using `Optional` instead of > `MaybeFileEntryRef`? Two problems: 1. `const FileEntry*` is stored in lots of places. I am nervous after the memory regression from

[PATCH] D89834: FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef

arphaman added a comment. What's wrong with using `Optional` instead of `MaybeFileEntryRef`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89834/new/ https://reviews.llvm.org/D89834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89834: FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef

dexonsmith added a comment. Note that https://reviews.llvm.org/D89836 is an example of a follow-up patch that leverages these API changes. The original version of that patch was much, much noisier. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89834/new/

[PATCH] D89834: FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef

dexonsmith updated this revision to Diff 299506. dexonsmith added a comment. Attaching the correct diff :/. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89834/new/ https://reviews.llvm.org/D89834 Files: clang/include/clang/Basic/FileEntry.h clang/unittests/Basic/CMakeLists.txt

[PATCH] D89834: FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef

dexonsmith created this revision. dexonsmith added reviewers: JDevlieghere, arphaman, teemperor. Herald added subscribers: llvm-commits, ributzka, mgorny. Herald added a project: LLVM. dexonsmith requested review of this revision. Make a few changes to the `FileEntryRef` API in preparation for