[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

2021-01-05 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9670 Info.MapTypesArray, Info.MappersArray, Info, - {/*ForEndTask=*/false, HasDependClauses}); +

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

2021-01-05 Thread Mike Rice via Phabricator via cfe-commits
mikerice added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9670 Info.MapTypesArray, Info.MappersArray, Info, - {/*ForEndTask=*/false, HasDependClauses}); +

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

2020-10-26 Thread Shilei Tian via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe20d64c3d9d8: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait (authored by tianshilei1992). Repository: rG LLVM Github

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

2020-10-26 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

2020-10-26 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 300754. tianshilei1992 added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Added a test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

2020-10-24 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added a comment. I don't think the failed case has anything to do with this patch. It must be a random issue in the bolt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

2020-10-23 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 300451. tianshilei1992 added a comment. Reverted changes for target data. It will be in another patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844 Files: