[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

2020-10-27 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D89893#2357480 , @Paul-C-Anagnostopoulos wrote: > I'll remember this, too. > > @dblaikie How did you happen to notice? Reading the mailing list & seeing the phab review and commit without any emails from anyone else in the r

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

2020-10-27 Thread Paul C. Anagnostopoulos via Phabricator via cfe-commits
Paul-C-Anagnostopoulos added a comment. I'll remember this, too. @dblaikie How did you happen to notice? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89893/new/ https://reviews.llvm.org/D89893 ___ cfe-

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

2020-10-27 Thread Chris Lattner via Phabricator via cfe-commits
lattner added a comment. Oops, thanks for the head's up @dblaikie ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89893/new/ https://reviews.llvm.org/D89893 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

2020-10-27 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added subscribers: mehdi_amini, dblaikie. dblaikie added a comment. @lattner minor detail/annoyance: Phabricator doesn't email the mailing lists if a review is "approved" with no comments. To ensure the approval is recorded on the list, please include some text (a stub "." would suffice

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

2020-10-22 Thread Paul C. Anagnostopoulos via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4b4543ff0c8: [Clang] [TableGen] Clean up !if(!eq(bool, 1) and related booleans (authored by Paul-C-Anagnostopoulos). Repository: rG LLVM Github M

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

2020-10-21 Thread Paul C. Anagnostopoulos via Phabricator via cfe-commits
Paul-C-Anagnostopoulos created this revision. Paul-C-Anagnostopoulos added reviewers: lattner, nhaehnle, asl. Herald added subscribers: cfe-commits, dexonsmith, dmgreen. Herald added a project: clang. Paul-C-Anagnostopoulos requested review of this revision. This patch continues the cleanup of boo