This revision was automatically updated to reflect the committed changes.
Closed by commit rGb698ad00cbc7: [clang][NFC] Rearrange Comment Token and Lexer
fields to reduce padding (authored by njames93).
Changed prior to commit:
https://reviews.llvm.org/D90127?vs=300623=300831#toc
Repository:
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/AST/CommentLexer.h:74
/// contains the length of the string that starts at TextPtr.
unsigned IntVal;
njames93 updated this revision to Diff 300623.
njames93 added a comment.
Fix field initialisation order in constructor
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90127/new/
https://reviews.llvm.org/D90127
Files:
njames93 added inline comments.
Comment at: clang/include/clang/AST/CommentLexer.h:244
+ /// command, including command marker.
+ SmallString<16> VerbatimBlockEndCommandName;
+
gribozavr2 wrote:
> I'm not a fan of this change to `Lexer` because it breaks the
njames93 updated this revision to Diff 300622.
njames93 added a comment.
Keep VerbatimBlockEndCommandName after LexerState while preserving smaller size
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90127/new/
https://reviews.llvm.org/D90127
gribozavr2 added inline comments.
Comment at: clang/include/clang/AST/CommentLexer.h:244
+ /// command, including command marker.
+ SmallString<16> VerbatimBlockEndCommandName;
+
I'm not a fan of this change to `Lexer` because it breaks the grouping of
njames93 created this revision.
njames93 added a reviewer: gribozavr2.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
njames93 requested review of this revision.
Rearrange the fields to reduce the size of the classes
Repository:
rG LLVM Github Monorepo
