[PATCH] D90194: [Driver] differentiate -stack-protector 0 from being unspecified

nickdesaulniers updated this revision to Diff 301458. nickdesaulniers added a comment. - rebase on D90271 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90194/new/ https://reviews.llvm.org/D90194 Files:

[PATCH] D90194: [Driver] differentiate -stack-protector 0 from being unspecified

nickdesaulniers added a comment. > It's trivial to not create a new enum value and always pass -stack-protector > along That was incorrect. Rebasing this on top of D90271 causes 49 test failures, because the diff I posted above didn't actually remove the

[PATCH] D90194: [Driver] differentiate -stack-protector 0 from being unspecified

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. I split out the first logical change into https://reviews.llvm.org/D90271. I think I'll rework this to both be rebased, and to not add the new enum value. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D90194: [Driver] differentiate -stack-protector 0 from being unspecified

nickdesaulniers added a comment. > An alternative approach to consider would be not adding a new enum, and > making -stack-protector ALWAYS be specified when invoking cc1. I did not > quantify the amount of changes to existing tests, but am happy to do so if > reviewers would like. Making

[PATCH] D90194: [Driver] differentiate -stack-protector 0 from being unspecified

nickdesaulniers created this revision. nickdesaulniers added reviewers: void, manojgupta, rnk. Herald added subscribers: cfe-commits, dexonsmith, pengfei. Herald added a project: clang. nickdesaulniers requested review of this revision. Follow up to: 1. commit b7926ce6d7a8