[PATCH] D90278: [ThinLTO] Fix .llvmcmd emission

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG735ab4be3569: [ThinLTO] Fix .llvmcmd emission (authored by mtrofin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90278: [ThinLTO] Fix .llvmcmd emission

tejohnson accepted this revision. tejohnson added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90278/new/ https://reviews.llvm.org/D90278 ___ cfe-commits mailing list

[PATCH] D90278: [ThinLTO] Fix .llvmcmd emission

mtrofin updated this revision to Diff 301391. mtrofin added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90278/new/ https://reviews.llvm.org/D90278 Files: clang/test/CodeGen/thinlto_embed_bitcode.ll

[PATCH] D90278: [ThinLTO] Fix .llvmcmd emission

mtrofin added a comment. In D90278#2359674 , @tejohnson wrote: > LGTM but is there a functional reason why CmdArgs was changed to be passed by > reference? If just generic cleanup might be better to split up that into a > separate commit. It avoids

[PATCH] D90278: [ThinLTO] Fix .llvmcmd emission

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM but is there a functional reason why CmdArgs was changed to be passed by reference? If just generic cleanup might be better to split up that into a separate commit. Repository:

[PATCH] D90278: [ThinLTO] Fix .llvmcmd emission

mtrofin created this revision. mtrofin added a reviewer: tejohnson. Herald added subscribers: llvm-commits, cfe-commits, steven_wu, hiraditya, inglorion. Herald added projects: clang, LLVM. mtrofin requested review of this revision. llvm::EmbedBitcodeInModule needs (what used to be called)