[PATCH] D90329: [PowerPC] Fix va_arg in Objective-C on 32-bit ELF targets

kernigh added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4723 + bool isInt = Ty->isIntegerType() || Ty->hasPointerRepresentation() || + Ty->isAggregateType(); bool isF64 = Ty->isFloatingType() && getContext().getTypeSize(Ty) == 64; ---

[PATCH] D90329: [PowerPC] Fix va_arg in Objective-C on 32-bit ELF targets

kernigh added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4723 + bool isInt = Ty->isIntegerType() || Ty->hasPointerRepresentation() || + Ty->isAggregateType(); bool isF64 = Ty->isFloatingType() && getContext().getTypeSize(Ty) == 64; ---

[PATCH] D90329: [PowerPC] Fix va_arg in Objective-C on 32-bit ELF targets

efriedma added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4723 + bool isInt = Ty->isIntegerType() || Ty->hasPointerRepresentation() || + Ty->isAggregateType(); bool isF64 = Ty->isFloatingType() && getContext().getTypeSize(Ty) == 64; --

[PATCH] D90329: [PowerPC] Fix va_arg in Objective-C on 32-bit ELF targets

kernigh added a comment. I'm using this TargetInfo.cpp diff in clang 10.0.1 on OpenBSD/macppc to build GNUstep. For me, it fixes the build of gnustep-gui. I rebuilt libobjc2, gnustep-make, and gnustep-base before building gnustep-gui. This diff doesn't change 64-bit PowerPC, because 64-bit does

[PATCH] D90329: [PowerPC] Fix va_arg in Objective-C on 32-bit ELF targets

kernigh created this revision. kernigh added reviewers: brad, nemanjai, efriedma. Herald added subscribers: cfe-commits, shchenz, kbarton. Herald added a project: clang. kernigh requested review of this revision. In the PPC32 SVR4 ABI, a va_list has copies of registers from the function call. va_