This revision was automatically updated to reflect the committed changes.
Closed by commit rG46ca880fcae2: clang: Dont assert on no_unique_address
fields in @encode() (authored by thakis).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90622/new/
https://reviews.llvm.org/D90622
___
cfe-commits mailing list
thakis added inline comments.
Comment at: clang/test/CodeGenObjCXX/encode.mm:91
- // CHECK: @_ZN11rdar93574002ggE = constant [49 x i8] c"{vector >=[4f]}\00"
+ // FIXME: This difference is due to D76801. It was probably an unintentional
change. Maybe we want to undo it?
+
thakis created this revision.
thakis added a reviewer: rjmccall.
thakis requested review of this revision.
Just skip (non-bitfield) zero-sized fields, like we do with empty bases.
The class->struct conversion in the test is because -std=c++20 else deletes
some default methods
due to
