[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c54b293373c: [clang-tidy] Extending bugprone-signal-handler with POSIX functions. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9085

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske updated this revision to Diff 325453. balazske added a comment. Rebase, improved documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 Files: clang-tools-extra/clang-tidy/bugprone/Signal

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 __

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske updated this revision to Diff 323340. balazske added a comment. Changed definition of size_t in test header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 Files: clang-tools-extra/clang-tidy/bu

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string.h:12 -void abort(void); -void _Exit(int); -void quick_exit(int); +typedef int size_t; I think this is causing some test failures: https://revie

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske updated this revision to Diff 322364. balazske added a comment. Update relative to previous commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 Files: clang-tools-extra/clang-tidy/bugprone/Si

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske updated this revision to Diff 322362. balazske added a comment. Added `quick_exit` to POSIX-allowed set. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 Files: clang-tools-extra/clang-tidy/bugpro

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-signal-handler.rst:29-30 + `_ + for more information). This is not an extension of the mi

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske updated this revision to Diff 321766. balazske added a comment. Re-organized testing header files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 Files: clang-tools-extra/clang-tidy/bugprone/Sig

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske added inline comments. Herald added a subscriber: nullptr.cpp. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-signal-handler-posix.c:4 +// RUN: [{key: bugprone-signal-handler.AsyncSafeFunctionSet, value: "POSIX"}]}' \ +// RUN: -- -isystem %S/Inputs/He

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

alexfh added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/system-header-posix-api.h:1 -//===--- signal.h - Stub header for tests ---*- C++ -*-===// +//===--- system-header-posix-api.h - Stub header for tests --*-

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-signal-handler.rst:29-30 + `_ + for more information). This is not an extension of the minimal

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/system-header-posix-api.h:1 -//===--- signal.h - Stub header for tests ---*- C++ -*-===// +//===--- system-header-posix-api.h - Stub header for tests -

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/system-header-posix-api.h:1 -//===--- signal.h - Stub header for tests ---*- C++ -*-===// +//===--- system-header-posix-api.h - Stub header for tests --

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.h:25 public: + enum class AsyncSafeFunctionSetType { Minimal, POSIX }; + balazske wrote: > aaron.ballman wrote: > > I don't think this needs to be public?

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske added a comment. In D90851#2385744 , @aaron.ballman wrote: > One thing that's not clear to me in the patch is what the behavior should be > when the user specifies that they want the POSIX set but they're compiling > for a non-POSIX system like

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

aaron.ballman added a comment. One thing that's not clear to me in the patch is what the behavior should be when the user specifies that they want the POSIX set but they're compiling for a non-POSIX system like Windows. Do you have thoughts on that situation? Comment at: clan

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske updated this revision to Diff 303356. balazske added a comment. Small fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 Files: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-signal-handler.rst:31 + is not included). Default is ``POSIX``. \ No newline at end of file Please add newline. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske created this revision. Herald added subscribers: cfe-commits, martong, gamesh411, Szelethus, dkrupp, xazax.hun, whisperity. Herald added a project: clang. balazske requested review of this revision. An option is added to the check to select wich set of functions is defined as asynchronou