This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG23a96b84a8d9: [AArch64][SVE] Support implicit lax vector
conversions for SVE types (authored by joechrisellis).
Repository:
rG LLVM Github
joechrisellis updated this revision to Diff 305494.
joechrisellis added a comment.
Remove failing test; it was checking that a conversion _failed_, although the
conversion should now _pass_ given the changes in this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
joechrisellis updated this revision to Diff 304811.
joechrisellis marked an inline comment as done.
joechrisellis added a comment.
- Support C lax vector conversions.
- Test C lax vector conversions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
fpetrogalli accepted this revision.
fpetrogalli added a comment.
This revision is now accepted and ready to land.
Thank you @joechrisellis - LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91067/new/
https://reviews.llvm.org/D91067
joechrisellis updated this revision to Diff 304469.
joechrisellis marked 3 inline comments as done.
joechrisellis added a comment.
Address @fpetrogalli's comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91067/new/
joechrisellis marked an inline comment as done.
joechrisellis added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:8563-8566
+if (const auto *BT = FirstType->getAs()) {
+ if (const auto *VT = SecondType->getAs()) {
+if (VT->getVectorKind() ==
fpetrogalli added a comment.
Hi @joechrisellis - thank you for this patch!
I have left a couple of comments.
Francesco
Comment at: clang/lib/AST/ASTContext.cpp:8563-8566
+if (const auto *BT = FirstType->getAs()) {
+ if (const auto *VT = SecondType->getAs()) {
+
joechrisellis added inline comments.
Comment at: clang/test/Sema/aarch64-sve-lax-vector-conversions.cpp:15
+typedef svint32_t fixed_int32_t FIXED_ATTR;
+typedef svint64_t fixed_int64_t FIXED_ATTR;
+
peterwaller-arm wrote:
> I can't see any uses of
joechrisellis updated this revision to Diff 303838.
joechrisellis marked an inline comment as done.
joechrisellis added a comment.
Address @peterwaller-arm's comment regarding unused types.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91067/new/
peterwaller-arm added a comment.
fixed_float64_t appears in the commit message but also is unused.
Comment at: clang/test/Sema/aarch64-sve-lax-vector-conversions.cpp:15
+typedef svint32_t fixed_int32_t FIXED_ATTR;
+typedef svint64_t fixed_int64_t FIXED_ATTR;
+
joechrisellis created this revision.
joechrisellis added reviewers: peterwaller-arm, fpetrogalli, DavidTruby.
Herald added subscribers: cfe-commits, psnobl, kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
Herald added a reviewer: efriedma.
Herald added a project: clang.
joechrisellis
11 matches
Mail list logo
