[PATCH] D91195: Add Annotation2MD pass to add !annotate metadata from llvm.global.annotations

2022-11-27 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Herald added subscribers: kosarev, ormris. Herald added a project: All. Comment at: llvm/lib/Transforms/IPO/Annotation2Metadata.cpp:51 +auto *StrGEP = dyn_cast(OpC->getOperand(1)); +if (!StrGEP || StrGEP->getNumOperands() < 2) +

[PATCH] D91195: Add Annotation2MD pass to add !annotate metadata from llvm.global.annotations

2020-11-16 Thread Florian Hahn via Phabricator via cfe-commits
fhahn marked an inline comment as done. fhahn added a comment. Thanks Jessica & Francis! I committed the initial version, with a small change to only run if the `!annotation` remarks are enabled. Comment at: llvm/include/llvm/Transforms/IPO/Annotation2Metadata.h:1 +//===-

[PATCH] D91195: Add Annotation2MD pass to add !annotate metadata from llvm.global.annotations

2020-11-16 Thread Florian Hahn via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dbe44cb2936: Add pass to add !annotate metadata from @llvm.global.annotations. (authored by fhahn). Herald added a project: clang. Herald added a