This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa1152482826c: [clangd] Add missing tests to rename feature
(authored by kbobyrev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
kbobyrev updated this revision to Diff 305070.
kbobyrev added a comment.
Move the rest of templated cases to appropriate location.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91337/new/
https://reviews.llvm.org/D91337
Files:
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:618
+
+ // Templated method instantiation.
+ R"cpp(
hokein wrote:
> nit: we
kbobyrev updated this revision to Diff 305047.
kbobyrev marked 4 inline comments as done.
kbobyrev added a comment.
Address the comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91337/new/
https://reviews.llvm.org/D91337
Files:
hokein added inline comments.
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:203
};
+struct D : B {
+ void [[f^oo]]() override {}
hmm, I'm not sure this is needed, I think it is identical with `C`.
kbobyrev created this revision.
kbobyrev added a reviewer: hokein.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman.
Herald added a project: clang.
kbobyrev requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
This adds a couple of missed tests
