This revision was automatically updated to reflect the committed changes.
Closed by commit rG9e407afd9bd3: [AIX][driver] Include crti[_64].o and -bcdtors
also for C language link… (authored by Xiangling_L).
Changed prior to commit:
https://reviews.llvm.org/D91361?vs=305160&id=305501#toc
Reposi
daltenty accepted this revision.
daltenty added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91361/new/
https://reviews.llvm.org/D91361
___
cfe-commits mailing list
cf
Xiangling_L updated this revision to Diff 305160.
Xiangling_L added a comment.
Remove the `if` condition and tweak the comments;
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91361/new/
https://reviews.llvm.org/D91361
Files:
clang/lib/Driver/ToolChains/AIX.cpp
clang/test/Driver/aix
daltenty added inline comments.
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:137
-if (D.CCCIsCXX())
+if (D.CCCIsCXX() || D.CCCIsCC())
CmdArgs.push_back(Args.MakeArgString(
Xiangling_L wrote:
> daltenty wrote:
> > I think that rather that addin
Xiangling_L added inline comments.
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:137
-if (D.CCCIsCXX())
+if (D.CCCIsCXX() || D.CCCIsCC())
CmdArgs.push_back(Args.MakeArgString(
daltenty wrote:
> I think that rather that adding CC, we should just
daltenty added inline comments.
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:137
-if (D.CCCIsCXX())
+if (D.CCCIsCXX() || D.CCCIsCC())
CmdArgs.push_back(Args.MakeArgString(
I think that rather that adding CC, we should just pull the if and
unc
Xiangling_L created this revision.
Xiangling_L added reviewers: daltenty, hubert.reinterpretcast, stevewan,
xingxue.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Xiangling_L requested review of this revision.
In order to support __attribute__((__constructor__)) and
__at
