[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG97d234935f15: [clang][Parse] Add parsing support for C++ attributes on using-declarations (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

ldionne updated this revision to Diff 348861. ldionne added a comment. Fix embarrassingly obvious oversight when I applied Aaron's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ https://reviews.llvm.org/D91630 Files: clang/do

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

ldionne updated this revision to Diff 348859. ldionne added a comment. Rebase onto `main`. I want to trigger CI again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ https://reviews.llvm.org/D91630 Files: clang/docs/LanguageExtensions.

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

ldionne added a comment. In D91630#2787438 , @thakis wrote: > This is breaking check-clang everywhere, eg > https://lab.llvm.org/buildbot/#/builders/109/builds/15757 > > Please run tests before landing, or failing that watch the bots after > committing.

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

ormris added a comment. This is also failing on several build bots: https://lab.llvm.org/buildbot/#/builders/139/builds/4812 Since it's been failing for a few hours, I'd like to revert this in the near future to unclog our internal CI and the buildbots. Repository: rG LLVM Github Monorepo

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

thakis added a comment. This is breaking check-clang everywhere, eg https://lab.llvm.org/buildbot/#/builders/109/builds/15757 Please run tests before landing, or failing that watch the bots after committing. Reverted in f63adf5b67f7a25b15f81d3a1a207aba4f226dc4 for now. Repository: rG LLVM

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

thakis added a comment. Looks like this breaks tests http://45.33.8.238/linux/47752/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ https://reviews.llvm.org/D91630 ___ cfe-commits mai

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc672999a9b1: [clang][Parse] Add parsing support for C++ attributes on using-declarations (authored by erik.pilkington, committed by ldionne). Repo

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

ldionne updated this revision to Diff 348547. ldionne marked 3 inline comments as done. ldionne added a comment. Apply review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ https://reviews.llvm.org/D91630 Files: clang/docs/La

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some minor nits. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3961 +def warn_deprecated_ignored_on_using : Warning< + "%0 currently has no effect on using-declarations">, + In

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

ldionne updated this revision to Diff 347069. ldionne marked an inline comment as done. ldionne added a comment. Herald added a project: clang. Rebase onto main and apply Aaron's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ htt

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a minor improvement for attribute ordering. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:732-733 +// Parse (optional) attributes. MaybeParseGNUAttributes(Attrs); +MaybeParseCXX11Attribut

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

erik.pilkington updated this revision to Diff 333862. erik.pilkington marked 4 inline comments as done. erik.pilkington added a comment. Address @aaron.ballman's review comments. Also, fix a bug where we failed to properly parse an inherited constructor declaration with a trailing attribute. CH

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

ldionne added a comment. Gentle ping! Can we merge this? I'd love to move forward with https://reviews.llvm.org/D90257. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ https://reviews.llvm.org/D91630 ___ cfe-commits mailing list cfe

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a few minor NFC changes and a documentation request. Thank you for this! Comment at: clang/docs/LanguageExtensions.rst:623 +C++11 Attributes on

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

erik.pilkington added a comment. In D91630#235 , @aaron.ballman wrote: > Can you mention this change in the release notes? Also, should we document it > explicitly in the Language Extensions documentation, or do you think this is > too tiny of a fea

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

erik.pilkington updated this revision to Diff 307669. erik.pilkington marked 6 inline comments as done. erik.pilkington added a comment. Herald added a subscriber: dexonsmith. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ https://reviews.llvm.org/D916

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

aaron.ballman added a comment. In D91630#2400731 , @rsmith wrote: > Do `[[deprecated]]` and `[[maybe_unused]]` now work for > //using-declarator//s? If so, a test for that would be useful. I think the answer is yes and no, respectively (at least in terms

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

rsmith added a comment. Do `[[deprecated]]` and `[[maybe_unused]]` now work for //using-declarator//s? If so, a test for that would be useful. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:714 - // C++11 attributes are not allowed on a using-declaration, but GNU ones - // a

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

Mordante added a comment. Thanks for the patch! No further comments regarding the patch, except the items Aaron already mentioned. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ https://reviews.llvm.org/D91630 ___ cfe-commits maili

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

aaron.ballman added inline comments. Comment at: clang/test/Parser/cxx0x-attributes.cpp:134 -[[]] using ns::i; // expected-error {{an attribute list cannot appear here}} +[[]] using ns::i; [[unknown]] using namespace ns; // expected-warning {{unknown attribute 'unknown' ignor

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

aaron.ballman added a comment. Can you mention this change in the release notes? Also, should we document it explicitly in the Language Extensions documentation, or do you think this is too tiny of a feature to warrant that? Comment at: clang/include/clang/Parse/Parser.h:2648

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

erik.pilkington created this revision. erik.pilkington added reviewers: aaron.ballman, rsmith, ldionne, Mordante. Herald added subscribers: jdoerfert, ributzka, jkorous. erik.pilkington requested review of this revision. This is split off from D90188 . https://re