[PATCH] D91656: [clang-tidy] add concurrency module

This revision was automatically updated to reflect the committed changes. Closed by commit rG8da7efbb0d5e: [clang-tidy] add concurrency module (authored by segoon, committed by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/

[PATCH] D91656: [clang-tidy] add concurrency module

segoon updated this revision to Diff 307979. segoon added a comment. - git dif -U CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-tools-extra/clang-tidy/ClangTidyForceLinker.h

[PATCH] D91656: [clang-tidy] add concurrency module

lebedev.ri added a comment. In D91656#2418790 , @segoon wrote: > - fix sort order Please always upload all patches with full context (`-U`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656

[PATCH] D91656: [clang-tidy] add concurrency module

segoon updated this revision to Diff 307883. segoon added a comment. - fix sort order CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-tools-extra/clang-tidy/ClangTidyForceLinker.h

[PATCH] D91656: [clang-tidy] add concurrency module

lebedev.ri added a comment. Not really, i think this should be landed together with it's dependee, which is not ready yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 ___ cfe-commits mailing list

[PATCH] D91656: [clang-tidy] add concurrency module

segoon added a comment. lebedev.ri, any comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91656: [clang-tidy] add concurrency module

segoon added a comment. In D91656#2411072 , @lebedev.ri wrote: > LGTM thanks for comments, fixed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 ___

[PATCH] D91656: [clang-tidy] add concurrency module

segoon updated this revision to Diff 307039. segoon added a comment. - sort order - do not link with FrontendOpenMP CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 Files: clang-tools-extra/clang-tidy/CMakeLists.txt

[PATCH] D91656: [clang-tidy] add concurrency module

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clang-tidy/CMakeLists.txt:57-58 add_subdirectory(bugprone) add_subdirectory(cert) add_subdirectory(cppcoreguidelines)

[PATCH] D91656: [clang-tidy] add concurrency module

segoon added a comment. jdoerfert, alexfh, hokein, aaron.ballman, Any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91656: [clang-tidy] add concurrency module

njames93 added a comment. LG, I have no further comments, though see what other say about this first. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 ___ cfe-commits mailing list

[PATCH] D91656: [clang-tidy] add concurrency module

segoon added a comment. In D91656#2402245 , @njames93 wrote: > Can you remove the code related to adding the mt-unsafe-posix check. Sorry, I've added unnecessary files. Removed now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/

[PATCH] D91656: [clang-tidy] add concurrency module

segoon updated this revision to Diff 306044. segoon added a comment. - remove garbage files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 Files: clang-tools-extra/clang-tidy/CMakeLists.txt

[PATCH] D91656: [clang-tidy] add concurrency module

njames93 added a comment. Can you remove the code related to adding the mt-unsafe-posix check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91656: [clang-tidy] add concurrency module

njames93 added a comment. Now that you have added the concurrency module as a new patch, all that code needs removing from this diff. If you generate the diff from that patch it should work. You should only be left with the code needed to add this check to that module. CHANGES SINCE LAST

[PATCH] D91656: [clang-tidy] add concurrency module

segoon updated this revision to Diff 306022. segoon retitled this revision from "[clang-tidy] add concurrent module" to "[clang-tidy] add concurrency module". segoon added a comment. - concurrent -> concurrency CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/