[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24d4291ca704: [CSSPGO] Pseudo probes for function calls. (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

wmi accepted this revision. wmi added a comment. This revision is now accepted and ready to land. In D91756#2427795 , @hoy wrote: > In D91756#2427759 , @wmi wrote: > >> Another question. Sorry for not bringing it

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy added a comment. In D91756#2427759 , @wmi wrote: > Another question. Sorry for not bringing it up earlier. When a call with > probe metadata attached is inlined, the probe will be gone or it will be kept > somehow? I think you want to keep the probe

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

wmi added a comment. Another question. Sorry for not bringing it up earlier. When a call with probe metadata attached is inlined, the probe will be gone or it will be kept somehow? I think you want to keep the probe especially for inline instance to reconstruct the context but I didn't figure

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy updated this revision to Diff 308874. hoy added a comment. Updating D91756 : [CSSPGO] Pseudo probes for function calls. Adding messages for asserts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91756/new/

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

wmi added inline comments. Comment at: llvm/include/llvm/IR/PseudoProbe.h:33-34 + static uint32_t packProbeData(uint32_t Index, uint32_t Type) { +assert(Index <= 0x); +assert(Type <= 0x7); +return (Index << 3) | (Type << 26) | 0x7; Add assertion

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy updated this revision to Diff 308806. hoy added a comment. Updating D91756 : [CSSPGO] Pseudo probes for function calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91756/new/ https://reviews.llvm.org/D91756

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy added inline comments. Comment at: llvm/lib/CodeGen/PseudoProbeInserter.cpp:50 +for (MachineBasicBlock : MF) { + MachineInstr *FirstInstr = nullptr; + for (MachineInstr : MBB) { wmi wrote: > What is the usage of FirstInstr? Good patch. It's

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

wmi added inline comments. Comment at: llvm/lib/CodeGen/PseudoProbeInserter.cpp:50 +for (MachineBasicBlock : MF) { + MachineInstr *FirstInstr = nullptr; + for (MachineInstr : MBB) { What is the usage of FirstInstr? Comment at:

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy updated this revision to Diff 306497. hoy added a comment. Updating D91756 : [CSSPGO] Pseudo probes for function calls. Corresponding changes to support IR/MIR intrinsic attributes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy updated this revision to Diff 306280. hoy edited the summary of this revision. hoy added a comment. Updating D91756 : [CSSPGO] Pseudo probes for function calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, wenlei, pengfei, hiraditya, mgorny. Herald added projects: clang, LLVM. hoy requested review of this revision. An indirect call site needs to be probed for its potential call targets. With CSSPGO a