This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
bsaleil marked an inline comment as done.
Closed by commit rG57d83c3a90c4: [PowerPC] Enable paired vector type and
intrinsics when MMA is disabled (authored by
bsaleil added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:1427
+ if (Target.getTriple().isPPC64() &&
+ Target.hasFeature("paired-vector-memops")) {
+if (Target.hasFeature("mma")) {
amyk wrote:
> Is it better to do `hasFeature()` over
saghir accepted this revision.
saghir added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91819/new/
https://reviews.llvm.org/D91819
___
amyk added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:1427
+ if (Target.getTriple().isPPC64() &&
+ Target.hasFeature("paired-vector-memops")) {
+if (Target.hasFeature("mma")) {
Is it better to do `hasFeature()` over `PairedVectorMemops`
bsaleil created this revision.
bsaleil added reviewers: nemanjai, saghir, amyk, lei.
bsaleil added projects: PowerPC, LLVM, clang.
Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, shchenz,
arphaman, martong, kbarton, hiraditya.
Herald added a reviewer: shafik.
bsaleil requested
