[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

aaron.ballman added a comment. In D91828#2411210 , @thejh wrote: > In D91828#2411207 , @aaron.ballman > wrote: > >> In D91828#2411203 , @thejh wrote: >> >>> @aaron.ballman C

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

thejh added a comment. In D91828#2411207 , @aaron.ballman wrote: > In D91828#2411203 , @thejh wrote: > >> @aaron.ballman Can you land it for me? I don't have commit access. > > Happy to do so -- are you okay with "

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

aaron.ballman added a comment. In D91828#2411203 , @thejh wrote: > @aaron.ballman Can you land it for me? I don't have commit access. Happy to do so -- are you okay with "Jann Horn " for author attribution? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

thejh added a comment. @aaron.ballman Can you land it for me? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91828/new/ https://reviews.llvm.org/D91828 ___ cfe-commits mailing

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91828/new/ https://reviews.llvm.org/D91828 ___ cfe-commits mailing list cfe-commit

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

thejh added inline comments. Comment at: clang/test/Frontend/noderef.c:71 + x = sizeof(s->a + (s->b)); // ok + // Nested struct access aaron.ballman wrote: > Can you add tests for the weird situations where the expression actually is > evaluated? e.g., > ```

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

thejh updated this revision to Diff 306792. thejh marked an inline comment as done. thejh added a comment. As requested by @aaron.ballman, added tests for edgecases where sizeof()/typeid() can cause memory access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

aaron.ballman added inline comments. Comment at: clang/test/Frontend/noderef.c:71 + x = sizeof(s->a + (s->b)); // ok + // Nested struct access Can you add tests for the weird situations where the expression actually is evaluated? e.g., ``` struct S { virtu

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM but you should probably also wait for @aaron.ballman or @rsmith to also chime in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

thejh updated this revision to Diff 306555. thejh added a comment. re-uploading to trigger a new build, since the build error looks unrelated. maybe current trunk is flaky? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91828/new/ https://reviews.ll

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

thejh created this revision. thejh added reviewers: leonardchan, rsmith, aaron.ballman, mcgrathr. Herald added a project: clang. Herald added a subscriber: cfe-commits. thejh requested review of this revision. The noderef attribute is for catching code that accesses pointers in a different address