[PATCH] D91844: [llvm][clang] Add checks for the smart pointers with the possibility to be null

2021-02-22 Thread Ella Ma via Phabricator via cfe-commits
OikawaKirie abandoned this revision. OikawaKirie added a comment. Split to - D97251 (clang/utils/TableGen/ClangAttrEmitter.cpp) - D97185 (llvm/lib/DWARFLinker/DWARFLinker.cpp) - D97254

[PATCH] D91844: [llvm][clang] Add checks for the smart pointers with the possibility to be null

2020-11-23 Thread Alexey Lapshin via Phabricator via cfe-commits
avl added a comment. The change for DWARFLinker is fine. I also think it is better to split the patch up into separate patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91844/new/ https://reviews.llvm.org/D91844

[PATCH] D91844: [llvm][clang] Add checks for the smart pointers with the possibility to be null

2020-11-22 Thread Ella Ma via Phabricator via cfe-commits
OikawaKirie added a comment. In D91844#2408897 , @dexonsmith wrote: > Is it possible to split these up into separate patches for unrelated code? Since these are reported by one static scan, and these reported places cannot be categorized with others, I

[PATCH] D91844: [llvm][clang] Add checks for the smart pointers with the possibility to be null

2020-11-20 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Is it possible to split these up into separate patches for unrelated code? Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:1346-1353 if (!Ptr) { // Search in reverse order so that the most-derived type is handled first. ArrayRef>

[PATCH] D91844: [llvm][clang] Add checks for the smart pointers with the possibility to be null

2020-11-19 Thread Ella Ma via Phabricator via cfe-commits
OikawaKirie created this revision. OikawaKirie added reviewers: aaron.ballman, avl, mehdi_amini, ilya-biryukov, tejohnson, jansvoboda11. OikawaKirie added projects: LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya. OikawaKirie requested review of