[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

This revision was automatically updated to reflect the committed changes. Closed by commit rG168be4208304: [Clang] Mutate long-double math builtins into f128 under IEEE-quad (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. I think it would be useful to run a functional test with a toolchain that has these library functions. That shouldn't gate this change though. CHANGES SINCE LAST ACTION

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

RKSimon added a reviewer: hfinkel. RKSimon added a comment. LGTM but a PPC-guru needs to signoff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new/ https://reviews.llvm.org/D92080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. Ping.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new/ https://reviews.llvm.org/D92080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. In D92080#2449236 , @craig.topper wrote: > D91675 has PowerPC only changes to make the > f128 calls get emitted. If you change the frontend in a target independent > way as proposed here, won't

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf updated this revision to Diff 312153. qiucf edited the summary of this revision. qiucf added a comment. - Diff based on pre-commit - Restrict to PPC64 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new/ https://reviews.llvm.org/D92080 Files:

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

craig.topper added a comment. In D92080#2448094 , @qiucf wrote: > In D92080#244 , @craig.topper > wrote: > >> I don't think I understand the whole picture here. Why would only builtins >> get mutated? Does a

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. In D92080#244 , @craig.topper wrote: > I don't think I understand the whole picture here. Why would only builtins > get mutated? Does a call to "modf" still call "modf"? But __builtin_modf will > call modf128? Is there a

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

craig.topper added a comment. I don't think I understand the whole picture here. Why would only builtins get mutated? Does a call to "modf" still call "modf"? But __builtin_modf will call modf128? Is there a corresponding patch to the runtime libcalls table in the backend? With -ffast-math

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

RKSimon added a comment. Please can you pre-commit math-builtins-adjust.c with current IR checks and then rebase to show the diffs? Maybe rename it math-builtins-long.c as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new/

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. Any comments...? I don't have knowledge if there's any plan about implementing `*f128` math functions on X86 libcs. But as I see so far, `*l` doesn't work well on `fp128`. Keeping this target independent currently seems reasonable to me. Repository: rG LLVM Github

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. In D92080#2416625 , @craig.topper wrote: > gcc calls the *l version with -mlong-double-128 on x86. Should we match gcc > here? Ah, yes, so this should be PPC-only change. But I see under x86 `-mlong-double-128`, std functions

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

craig.topper added a comment. gcc calls the *l version with -mlong-double-128 on x86. Should we match gcc here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new/ https://reviews.llvm.org/D92080

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf created this revision. qiucf added reviewers: craig.topper, spatel, nemanjai, jsji, steven.zhang, PowerPC, kpn, RKSimon. Herald added subscribers: cfe-commits, pengfei. Herald added a project: clang. qiucf requested review of this revision. Under `-mlong-double-128` on x86 and