[PATCH] D92434: [NFC][AMDGPU] AMDGPU code object V4 ABI documentation

2021-01-05 Thread Artem Belevich via Phabricator via cfe-commits 
tra added inline comments.



Comment at: llvm/docs/AMDGPUUsage.rst:959
+ = = =
+ ``EF_AMDGPU_FEATURE_XNACK_V2``0x01  Indicates if the ``xnack``
+ target feature is

Where do these flags live?
I do not see them in 
https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/BinaryFormat/ELF.h#L738

Do these doc changes reflect a patch that did not land yet?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92434/new/

https://reviews.llvm.org/D92434

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92434: [NFC][AMDGPU] AMDGPU code object V4 ABI documentation

2020-12-01 Thread Konstantin Zhuravlyov via Phabricator via cfe-commits 
kzhuravl accepted this revision.
kzhuravl added a comment.
This revision is now accepted and ready to land.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92434/new/

https://reviews.llvm.org/D92434

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits