[PATCH] D92756: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions.

2020-12-15 Thread Nathan James via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68e642cad024: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions. (authored by njames93). Repository: rG LLVM Github

[PATCH] D92756: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions.

2020-12-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92756/new/ https://reviews.llvm.org/D92756

[PATCH] D92756: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions.

2020-12-12 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 311388. njames93 added a comment. Fix test failures and added some to demonstrate this behaviour. Haven't added exhaustive cases as they are present in the YAML parser tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92756: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions.

2020-12-07 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 309985. njames93 added a comment. Refactored based on changes to parent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92756/new/ https://reviews.llvm.org/D92756 Files:

[PATCH] D92756: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions.

2020-12-07 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Is there a way to add test coverage for this to demonstrate that we handle what YAML considers a Boolean and that we don't allow oddities? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92756/new/

[PATCH] D92756: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions.

2020-12-07 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added a reviewer: aaron.ballman. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D92755 Repository: rG