This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdad07baf123e: [clang][AArch64][SVE] Avoid going through
memory for VLAT - VLST casts (authored by joechrisellis).
Repository:
rG LLVM Github
joechrisellis updated this revision to Diff 312150.
joechrisellis added a comment.
Address @c-rhodes's comments.
- Add a comment stating that we intend to eliminate going through memory when
the element types of the vectors are not the same (for example, with
predicates).
- Doc comments for
c-rhodes accepted this revision.
c-rhodes added a comment.
This revision is now accepted and ready to land.
Left a couple of nits but mostly LGTM, cheers
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2025-2051
// Perform VLAT <-> VLST bitcast through memory.
if
aeubanks resigned from this revision.
aeubanks added a comment.
I'm unfamiliar with this code
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92761/new/
https://reviews.llvm.org/D92761
___
cfe-commits
joechrisellis added reviewers: c-rhodes, aeubanks.
joechrisellis added subscribers: aeubanks, c-rhodes.
joechrisellis added a comment.
Adding reviewers @c-rhodes and @aeubanks because `git blame` tells me they've
touched the surrounding code.
Repository:
rG LLVM Github Monorepo
CHANGES
joechrisellis updated this revision to Diff 310529.
joechrisellis added a comment.
Herald added a subscriber: NickHung.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92761/new/
https://reviews.llvm.org/D92761
Files:
joechrisellis created this revision.
joechrisellis added reviewers: peterwaller-arm, DavidTruby.
Herald added subscribers: psnobl, kristof.beyls, tschuett.
Herald added a reviewer: efriedma.
joechrisellis requested review of this revision.
Herald added projects: clang, LLVM.
Herald added
