[PATCH] D92797: APINotes: add initial stub of APINotesWriter

dyung added a comment. In D92797#4596289 , @ronlieb wrote: > hi, this seems to be breaking out amdgpu opemp and hip buildbots > https://lab.llvm.org/staging/#/builders/247/builds/4967 And also some GCC based bots:

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

ronlieb added a comment. hi, this seems to be breaking out amdgpu opemp and hip buildbots https://lab.llvm.org/staging/#/builders/247/builds/4967 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf806be5eaae1: APINotes: add initial stub of APINotesWriter (authored by Saleem Abdulrasool abdul...@google.com, committed by compnerd). Changed

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

egorzhdan added a comment. @compnerd @martong would you be OK with merging this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797 ___ cfe-commits mailing

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

egorzhdan added a comment. Apologies for pinging an old review. Would it be possible to land this to facilitate future work to upstream API notes support? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added a comment. Welcome back, hope you had a good time off. Thanks for the review! Comment at: clang/lib/APINotes/APINotesWriter.cpp:35 + bool SwiftImportAsMember = false; +#endif + martong wrote: > compnerd wrote: > > Please ignore this

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. In D92797#2505254 , @compnerd wrote: > Ping x 3 Sorry, just came back from holidays. Generally, I have no major concerns. My minor concern is that

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added a comment. Ping x 3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added a comment. Ping x 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added a comment. Gentle post-holiday ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added inline comments. Comment at: clang/include/clang/APINotes/APINotesWriter.h:1 +//===-- APINotesWriter.h - API Notes Writer -*- C++ -*-===// +// martong wrote: > How are we going to use this class? I mean what are the use cases

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

martong added a comment. In D92797#2452497 , @compnerd wrote: > Ping I am terribly sorry for keeping you waiting always. Thanks for your patience. Comment at: clang/include/clang/APINotes/APINotesWriter.h:1 +//===-- APINotesWriter.h -

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added inline comments. Comment at: clang/lib/APINotes/APINotesWriter.cpp:35 + bool SwiftImportAsMember = false; +#endif + Please ignore this `#if`-defed portion, it is not intended for upstream, but I need to keep this working downstream. I will

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd created this revision. compnerd added reviewers: martong, gribozavr2, MForster. Herald added subscribers: mgrang, rnkovacs, mgorny. compnerd requested review of this revision. Herald added a project: clang. This adds the skeleton for serializing out the APINotes data from the APINotes.