This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7d246cb19db9: [flang][driver] Add support for
`-fsyntax-only` (authored by awarzynski).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
CarolineConcatto accepted this revision.
CarolineConcatto added a comment.
Thank you @awarzynski for implementing fsyntax-only.
It is another feature that the new driver provides, it is nice to see thing
falling into place.
The patch looks good to me!
Comment at:
awarzynski updated this revision to Diff 312547.
awarzynski added a comment.
Tidy-up include paths
This was pointed out by @CarolineConcatto offline, thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92854/new/
awarzynski updated this revision to Diff 312400.
awarzynski added a comment.
Rebased on top of main
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92854/new/
https://reviews.llvm.org/D92854
Files:
clang/include/clang/Driver/Options.td
awarzynski updated this revision to Diff 311925.
awarzynski added a comment.
Address comment from @CarolineConcatto + rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92854/new/
https://reviews.llvm.org/D92854
Files:
awarzynski added inline comments.
Comment at: flang/lib/Frontend/FrontendActions.cpp:87
+ defaultKinds, features, ci.allCookedSources()};
+ semanticsContext.set_moduleDirectory("."s);
+ Fortran::semantics::Semantics semantics{
CarolineConcatto wrote:
>
CarolineConcatto added inline comments.
Comment at: flang/lib/Frontend/FrontendActions.cpp:87
+ defaultKinds, features, ci.allCookedSources()};
+ semanticsContext.set_moduleDirectory("."s);
+ Fortran::semantics::Semantics semantics{
Just a quick question:
sameeranjoshi accepted this revision.
sameeranjoshi added a comment.
This revision is now accepted and ready to land.
Looks good from my end.
Thank you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92854/new/
https://reviews.llvm.org/D92854
awarzynski updated this revision to Diff 311231.
awarzynski added a comment.
Fine-tune the output for consistency with `flang`/`f18`
This is just a minor change to make sure that:
- `flang-new -fc1 -fsyntax-only`, and
- `f18 -fparse-only`
are as similar as possible.
Repository:
rG LLVM
awarzynski updated this revision to Diff 310952.
awarzynski added a comment.
Update according to PR comments
- extracted the `-triple` related part into https://reviews.llvm.org/D93027
- made sure that `flang-new` and `flang-new -fc1` return error when semantic
checks fail
- fixed typos
awarzynski marked 4 inline comments as done.
awarzynski added a comment.
Thank you for your reviews! I'll submit an updated patch shortly.
Comment at: clang/lib/Driver/ToolChains/Flang.cpp:43-44
} else if (isa(JA) || isa(JA)) {
-CmdArgs.push_back("-triple");
-
sameeranjoshi added a comment.
Thanks for patch, a few queries below.
Are the tests in clang which are related to flang failing at
https://reviews.llvm.org/B81474?
Comment at: flang/include/flang/Frontend/FrontendActions.h:29
+class SyntaxOnlyAction : public FrontendAction
kiranchandramohan added a comment.
A few comments.
Comment at: clang/lib/Driver/ToolChains/Flang.cpp:43-44
} else if (isa(JA) || isa(JA)) {
-CmdArgs.push_back("-triple");
-CmdArgs.push_back(Args.MakeArgString(TripleStr));
if (JA.getType() == types::TY_Nothing)
awarzynski created this revision.
Herald added subscribers: dang, mgorny.
Herald added a reviewer: sscalpone.
awarzynski requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D92854
14 matches
Mail list logo
