[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfa1010c4242: [clangd] Provide suggestions with invalid config keys (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

njames93 updated this revision to Diff 311949. njames93 marked 2 inline comments as done. njames93 added a comment. Last nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92990/new/ https://reviews.llvm.org/D92990 Files:

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, thanks! Comment at: clang-tools-extra/clangd/ConfigYAML.cpp:27 +static llvm::Optional +bestGuess(llvm::StringRef Search, (nit: no need for

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

njames93 updated this revision to Diff 311934. njames93 marked 3 inline comments as done. njames93 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92990/new/ https://reviews.llvm.org/D92990 Files:

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

sammccall added a subscriber: hokein. sammccall added a comment. Sorry about being slow here. Just a couple of suggestions to avoid cluttering the config parsing bits too much, and IIUC fixits can be removed. Comment at: clang-tools-extra/clangd/ConfigYAML.cpp:211 +

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

njames93 added a comment. In D92990#2446097 , @sammccall wrote: > This is cool! Detecting basic typos could save a fair bit of time. > I do want to be a bit wary of spending too much complexity on small > enhancements to rarely used code - if it's more

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

njames93 updated this revision to Diff 311067. njames93 marked 3 inline comments as done. njames93 added a comment. Address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92990/new/ https://reviews.llvm.org/D92990 Files:

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

sammccall added a comment. This is cool! Detecting basic typos could save a fair bit of time. I do want to be a bit wary of spending too much complexity on small enhancements to rarely used code - if it's more than a simple typo we're correcting, then I think it's ok to make the user look it

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

njames93 added a comment. Adding in support for fix-its(at least in vscode) didn't seem to work. The language server there doesn't seem to send the `textDocument/codeAction` message to the server for the `.clangd` file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

njames93 updated this revision to Diff 310814. njames93 added a comment. Fix lit test failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92990/new/ https://reviews.llvm.org/D92990 Files: clang-tools-extra/clangd/ConfigYAML.cpp

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Update the config file warning