This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG95114f21f5bf: [clang][cli] Do not marshall only CC1Option
flags in BoolOption (authored by jansvoboda11).
Changed prior to commit:
Bigcheese accepted this revision.
Bigcheese added a comment.
This revision is now accepted and ready to land.
lgtm.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93008/new/
https://reviews.llvm.org/D93008
jansvoboda11 requested review of this revision.
jansvoboda11 added a comment.
@Bigcheese, can you please go through this again and let me know it it looks
good to you now?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93008/new/
jansvoboda11 updated this revision to Diff 311134.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.
Add forgotten CC1Option check in parsing macro, extract denormalizer changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
dexonsmith accepted this revision.
dexonsmith added a comment.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93008/new/
https://reviews.llvm.org/D93008
___
cfe-commits mailing list
jansvoboda11 updated this revision to Diff 310792.
jansvoboda11 added a comment.
Fix comment typo
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93008/new/
https://reviews.llvm.org/D93008
Files:
clang/include/clang/Driver/Options.td
jansvoboda11 created this revision.
jansvoboda11 added reviewers: dexonsmith, Bigcheese.
Herald added a subscriber: dang.
jansvoboda11 requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
We cannot be sure whether a flag is
