[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

2020-12-17 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. Ah, this may be one of the things aomp changed for nvptx. We did something around linking but I've never looked into exactly what. In that case fine by me - it's a sharp edge, but I'd expect it to make a difference in benchmarks until whole program optimisation

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

2020-12-17 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 312535. jdoerfert added a comment. Rebase on top of D93439 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93079/new/ https://reviews.llvm.org/D93079 Files:

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

2020-12-15 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D93079#2451782 , @JonChesterfield wrote: > Is this for cases where we are compiling a subset of the target code, i.e. > without link time optimisation? Upstream cannot to LTO on any target code as of now :( > It's

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

2020-12-14 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. Is this for cases where we are compiling a subset of the target code, i.e. without link time optimisation? It's interesting that we might want a static function on the gpu and an external one on the cpu. The user could presumably make it static and provide a

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

2020-12-10 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 311106. jdoerfert added a comment. Add remark summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93079/new/ https://reviews.llvm.org/D93079 Files: clang/include/clang/Basic/AttrDocs.td

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

2020-12-10 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 311105. jdoerfert added a comment. Herald added a reviewer: aaron.ballman. Herald added projects: clang, OpenMP. Herald added a subscriber: cfe-commits. Add remark and documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION