[PATCH] D93138: Add initial support for multilibs in Baremetal toolchain.

2022-07-31 Thread Zixuan Wu via Phabricator via cfe-commits
zixuan-wu added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:177 if (!getDriver().SysRoot.empty()) -return getDriver().SysRoot; +return getDriver().SysRoot + SelectedMultilib.osSuffix(); abidh wrote: > zixuan-wu wrote: > >

[PATCH] D93138: Add initial support for multilibs in Baremetal toolchain.

2022-07-29 Thread Hafiz Abid Qadeer via Phabricator via cfe-commits
abidh added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:177 if (!getDriver().SysRoot.empty()) -return getDriver().SysRoot; +return getDriver().SysRoot + SelectedMultilib.osSuffix(); zixuan-wu wrote: > I think the multilib

[PATCH] D93138: Add initial support for multilibs in Baremetal toolchain.

2022-07-26 Thread Zixuan Wu via Phabricator via cfe-commits
zixuan-wu added inline comments. Herald added subscribers: pcwang-thead, luke957, StephenFan, MaskRay, arichardson. Herald added a project: All. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:177 if (!getDriver().SysRoot.empty()) -return getDriver().SysRoot; +

[PATCH] D93138: Add initial support for multilibs in Baremetal toolchain.

2020-12-14 Thread Hafiz Abid Qadeer via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. abidh marked 3 inline comments as done. Closed by commit rG670686ad8ecc: Add initial support for multilibs in Baremetal toolchain. (authored by abidh). Herald added a project: clang. Herald added a subscriber: cfe-commits.