[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfae0dfa6421e: [Clang] Add __ibm128 type to represent ppc_fp128 (authored by qiucf). Changed prior to commit:

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, thanks. LGTM, then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5159 BT->getKind() == BuiltinType::LongDouble || +BT->getKind() == BuiltinType::Ibm128 || (getContext().getTargetInfo().hasFloat128Type() && rjmccall wrote: >

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf updated this revision to Diff 369045. qiucf marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 Files: clang/bindings/python/clang/cindex.py

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

rjmccall added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:131 +Float128, +Ibm128 }; qiucf wrote: > rjmccall wrote: > > This is necessary because it's possible to derive this type from a mode > > attribute? > Yes,

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf marked 2 inline comments as done. qiucf added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:131 +Float128, +Ibm128 }; rjmccall wrote: > This is necessary because it's possible to derive this type from a mode > attribute?

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

akyrtzi added inline comments. Comment at: clang/lib/Index/USRGeneration.cpp:708 c = 'd'; break; +case BuiltinType::Ibm128: // FIXME: Need separate tag case BuiltinType::LongDouble: rjmccall wrote: > @akyrtzi @benlangmuir We can just

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

rjmccall added subscribers: akyrtzi, benlangmuir. rjmccall added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:131 +Float128, +Ibm128 }; This is necessary because it's possible to derive this type from a mode attribute?

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added a comment. Ping.. Any further comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

rjmccall added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2668 // ::= g # __float128 + // ::= g # __ibm128 // UNSUPPORTED:::= Dd # IEEE 754r decimal floating point (64 bits) jwakely wrote: >

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

jwakely added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2668 // ::= g # __float128 + // ::= g # __ibm128 // UNSUPPORTED:::= Dd # IEEE 754r decimal floating point (64 bits) steven.zhang wrote: > This

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added inline comments. Comment at: clang/bindings/python/clang/cindex.py:2061-2062 TypeKind.FLOAT128 = TypeKind(30) TypeKind.HALF = TypeKind(31) +TypeKind.IBM128 = TypeKind(32) TypeKind.COMPLEX = TypeKind(100) hubert.reinterpretcast wrote: > This looks

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf updated this revision to Diff 330560. qiucf marked an inline comment as done. qiucf added a comment. Update cindex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 Files:

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/bindings/python/clang/cindex.py:2061-2062 TypeKind.FLOAT128 = TypeKind(30) TypeKind.HALF = TypeKind(31) +TypeKind.IBM128 = TypeKind(32) TypeKind.COMPLEX = TypeKind(100) This looks suspiciously

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; jwakely wrote: > hubert.reinterpretcast wrote: > >

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

jwakely added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; hubert.reinterpretcast wrote: > jwakely wrote: > >

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; jwakely wrote: > hubert.reinterpretcast wrote: > >

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

jwakely added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; hubert.reinterpretcast wrote: > qiucf wrote: > >

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; qiucf wrote: > hubert.reinterpretcast wrote: > >

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; hubert.reinterpretcast wrote: > qiucf wrote: > >

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf updated this revision to Diff 327716. qiucf marked 2 inline comments as done. qiucf added a comment. - Add helper method to count 'unordered' cases - Add missing tests (in last update) - Add test for openmp device-host case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

rjmccall added a comment. In D93377#2481957 , @hubert.reinterpretcast wrote: > In D93377#2481312 , @rjmccall wrote: > >> Are you committed to the name `__ibm128`? > > Insofar as that's what GCC on Power (for

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added a comment. In D93377#2481312 , @rjmccall wrote: > Are you committed to the name `__ibm128`? Insofar as that's what GCC on Power (for example, `gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0` from 2017) has shipped with for several

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

rjmccall added a comment. Are you committed to the name `__ibm128`? I think a name that says something about floating point would be better than just a company name and a number. "double double" is the common name for this format pretty much everywhere, and while I certainly would *not*

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6230 /// LHS < RHS, return -1. int ASTContext::getFloatingTypeOrder(QualType LHS, QualType RHS) const { FloatingRank LHSR = getFloatingRank(LHS); qiucf wrote: >

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6204 case HalfRank: llvm_unreachable("Complex half is not supported"); +case Ibm128Rank: llvm_unreachable("Complex __ibm128 is not supported"); case FloatRank: return FloatComplexTy;

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf updated this revision to Diff 313835. qiucf marked 14 inline comments as done. qiucf added a comment. Address comments and add tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 Files: clang/bindings/python/clang/cindex.py

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6230 /// LHS < RHS, return -1. int ASTContext::getFloatingTypeOrder(QualType LHS, QualType RHS) const { FloatingRank LHSR = getFloatingRank(LHS); nemanjai wrote: >

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

nemanjai added a comment. Seems that conversion diagnostic test cases are completely missing. Comment at: clang/include/clang/Basic/TargetInfo.h:680 + /// Return the mangled code of __ibm128. + virtual const char *getIbm128Mangling() const { return "g"; } +

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGenCXX/ibm128-declarations.cpp:25 + +__ibm128 func4(__ibm128 a, __ibm128 b) { + return a + b; hubert.reinterpretcast wrote: > hubert.reinterpretcast wrote: > > There's a lot of missing

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6230 /// LHS < RHS, return -1. int ASTContext::getFloatingTypeOrder(QualType LHS, QualType RHS) const { FloatingRank LHSR = getFloatingRank(LHS); I think this function

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

steven.zhang added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2668 // ::= g # __float128 + // ::= g # __ibm128 // UNSUPPORTED:::= Dd # IEEE 754r decimal floating point (64 bits) This is a bit

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf created this revision. qiucf added reviewers: nemanjai, rjmccall, rsmith, hubert.reinterpretcast, akyrtzi, PowerPC. Herald added subscribers: dexonsmith, steven.zhang, shchenz, arphaman, kbarton. qiucf requested review of this revision. Herald added a reviewer: jdoerfert. Herald added