[PATCH] D93528: [clang-format] Add basic support for formatting JSON

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b7881a084d0: [clang-format] Add basic support for formatting JSON (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D93528?vs=353570=354674#toc Repository: rG LLVM

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay added a comment. ping, if there are no other opinions I plan to land this sometime this weekend. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/ https://reviews.llvm.org/D93528 ___ cfe-commits mailing list

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. @HazardyKnusperkeks thank you for the accept, if there are no objections from @curdeius , @krasimir and @sammccall I'd like to proceed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:284 +- Basic Support has been adding for Formatting .json files (with very limited options) + curdeius wrote: > Maybe instead of

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay updated this revision to Diff 353570. MyDeveloperDay added a comment. - Add release note - Add default Column Limit of 0 for default Json Style (add unit test to ensure column limits can still be used) - this minimises the differences between what Notepad++'s JSON Format plugin

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay added a comment. something @sammccall said about support `foo["name"]` made me realise that our javascript support doesn't always support what all the options x = { "firstName" : "John", "lastName" : "Smith", "isAlive" : true, "age" : 27, "address" : {

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay updated this revision to Diff 353295. MyDeveloperDay added a comment. Add more unit tests and ensure clang-format-diff is setup to check json CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/ https://reviews.llvm.org/D93528 Files: clang/docs/ClangFormat.rst

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay updated this revision to Diff 353290. MyDeveloperDay added a comment. Ensure git clang-format can handle json CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/ https://reviews.llvm.org/D93528 Files: clang/docs/ClangFormat.rst

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

HazardyKnusperkeks added a reviewer: HazardyKnusperkeks. HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Nice trick! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay updated this revision to Diff 352773. MyDeveloperDay added a comment. JSON strings can't be split when the line is too long like c++ strings CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/ https://reviews.llvm.org/D93528 Files: clang/docs/ClangFormat.rst

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay updated this revision to Diff 352750. MyDeveloperDay added a comment. Missing new test file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/ https://reviews.llvm.org/D93528 Files: clang/docs/ClangFormat.rst clang/docs/ClangFormatStyleOptions.rst

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay updated this revision to Diff 352744. MyDeveloperDay added a comment. I have reworked this patch to utilise the fact that clang-format can format a JSON object in javascript reasonably well. This technique adds for JSON files only a replacement to the front of the JSON

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. > With my maintainer-of-`Support/JSON` hat on, I don't like the idea of these > features being shoehorned into the library to make clang-format an > incrementally more featureful JSON formatter. They're likely to

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

sammccall added a comment. In theory, this version doesn't seem so useful - a simple JSON pretty-printer that ignores column widths etc is easy to write, doesn't need any of clang-format's infrastructure, and this isn't a particularly great one. In practice though, not having to configure yet

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

curdeius added a comment. In D93528#2463030 , @HazardyKnusperkeks wrote: > In D93528#2462969 , @MyDeveloperDay > wrote: > >> So I guess my question is: >> >> 1. is this useful to pursue (either as is, or by

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

HazardyKnusperkeks added a comment. In D93528#2462969 , @MyDeveloperDay wrote: > So I guess my question is: > > 1. is this useful to pursue (either as is, or by switching to us the reformat > method) > 2. is this useful standalone as the first pass > 3.

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay added a comment. In D93528#2462723 , @curdeius wrote: > Why not using clang-format's support for JavaScript? It seems more > complicated now, but it will probably allow to more easily change/add style > options. WDYT? > And what happens

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

curdeius added a comment. Why not using clang-format's support for JavaScript? It seems more complicated now, but it will probably allow to more easily change/add style options. WDYT? And what happens when reformatting only a part of a JSON? Should there be some tests for that? Repository:

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, krasimir, klimek, sammccall, benhamilton. MyDeveloperDay added projects: clang, clang-format. Herald added a subscriber: mgorny. MyDeveloperDay requested review of this revision. I find as I develop I'm moving