rapgenic updated this revision to Diff 314718.
rapgenic marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93763/new/
https://reviews.llvm.org/D93763
Files:
clang-tools-extra/clangd/ClangdLSPServer.cpp
clang-tools-extra/clangd/ClangdLSPServer.h
rapgenic marked 4 inline comments as done.
rapgenic added a comment.
> In the future it may make sense to have other documentLinks too. (e.g.
> imagine a comment Configures the Frobnicator - we should linkify Frobnicator
> to point to a class, once documentLink supports target ranges). So we
sammccall added a comment.
Seems fair enough to do something about this, though it's a bit sad we're doing
it just because VSCode has bad UI.
A couple of open design questions:
1. In the future it may make sense to have other documentLinks too. (e.g.
imagine a comment `Configures the
rapgenic updated this revision to Diff 313667.
rapgenic added a comment.
Fix formatting
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93763/new/
https://reviews.llvm.org/D93763
Files:
clang-tools-extra/clangd/ClangdLSPServer.cpp
clang-tools-extra/clangd/ClangdLSPServer.h
njames93 added a comment.
Can you apply the clang-format patch suggested by the pre-merge bot.
Alternatively, if you have a recent version of clang-format and the appropriate
git-hooks you should be able to run `git clang-format` for the same effect.
Repository:
rG LLVM Github Monorepo
rapgenic created this revision.
Herald added subscribers: usaxena95, kadircet, arphaman.
rapgenic requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
On some editors (namely VSCode) documentLinks are rendered with an
