[PATCH] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers

troyj added a comment. Hi, I got here via llvm-dev => https://reviews.llvm.org/D9375 => https://reviews.llvm.org/D9403 (this) and have read through everything. I see that this patch has been stalled for about a year and I would like to know its status. Is it waiting on a resolution in LLVM

[PATCH] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers

hfinkel updated this revision to Diff 29. hfinkel added a comment. Herald added a subscriber: javed.absar. Rebased and addressing review comments. https://reviews.llvm.org/D9403 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGStmt.cpp

[PATCH] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers

hfinkel added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1291 +// where the pointer to the local variable is the key in the map. +void CodeGenFunction::EmitAutoVarNoAlias(const AutoVarEmission ) { + assert(emission.Variable && "emission was not valid!");

[PATCH] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers

rjmccall added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1291 +// where the pointer to the local variable is the key in the map. +void CodeGenFunction::EmitAutoVarNoAlias(const AutoVarEmission ) { + assert(emission.Variable && "emission was not valid!");

[PATCH] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers

hfinkel added a comment. Ping. https://reviews.llvm.org/D9403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers

hfinkel updated this revision to Diff 73344. hfinkel added a comment. Rebased; added more comments and addressed other review feedback. https://reviews.llvm.org/D9403 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGStmt.cpp lib/CodeGen/CodeGenFunction.cpp

[PATCH] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers

hfinkel added inline comments. > rjmccall wrote in CGStmt.cpp:525 > It's much more likely that NoAliasScopes will be empty than that MemoryInsts > will be empty. You should probably fast-path using that, or better yet, with > the RecordMemoryInsts bit. I'm not sure that's true; we only

Re: [PATCH] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers

rjmccall added inline comments. Comment at: lib/CodeGen/CGStmt.cpp:525 @@ +524,3 @@ +void CodeGenFunction::LexicalNoAliasInfo::addNoAliasMD() { + if (MemoryInsts.empty() || NoAliasScopes.empty()) +return; It's much more likely that NoAliasScopes will be

Re: [PATCH] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers

hfinkel added inline comments. Comment at: lib/CodeGen/CGStmt.cpp:537 @@ +536,3 @@ + llvm::LLVMContext::MD_noalias), + NewScopeList)); + rjmccall wrote: > This is a very strange

Re: [PATCH] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers

rjmccall added inline comments. Comment at: lib/CodeGen/CGStmt.cpp:537 @@ +536,3 @@ + llvm::LLVMContext::MD_noalias), + NewScopeList)); + This is a very strange representation. Every

Re: [PATCH] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers

hfinkel updated this revision to Diff 63394. hfinkel added a comment. Herald added a subscriber: mcrosier. Rebased. Recursive AST visitor (which John pointed out was bad because it caused quadratic behavior and was wasteful in terms of code size) replaced with a function with some loops over