[PATCH] D94364: [clang] Allow specifying the aapcs and aapcs-vfp for windows on arm

rnk added a comment. I don't see how supporting this attribute would break interop with MSVC. MSVC doesn't support these attributes, only GCC and Clang do. Presumably in the wine environment, some headers using these _GNUC extensions are being included somewhere, and IMO we should accept the at

[PATCH] D94364: [clang] Allow specifying the aapcs and aapcs-vfp for windows on arm

compnerd added a comment. I think that it makes more sense to ignore the `aapcs-vfp` calling convention attribute (returning `CCCR_Ignore`), and warn on the `aapcs`. The redundant calling convention attribute does nothing, and I think that simply ignoring it would solve your issue. However, c

[PATCH] D94364: [clang] Allow specifying the aapcs and aapcs-vfp for windows on arm

mstorsjo added a comment. In D94364#2490743 , @compnerd wrote: > Can you please add some more context around the motivation for this change? > It seems ... unnecessary as everything is already AAPCS/AAPCS-VFP. Yeah it's a redundant attribute, but I don'

[PATCH] D94364: [clang] Allow specifying the aapcs and aapcs-vfp for windows on arm

compnerd added a comment. Can you please add some more context around the motivation for this change? It seems ... unnecessary as everything is already AAPCS/AAPCS-VFP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94364/new/ https://reviews.llvm

[PATCH] D94364: [clang] Allow specifying the aapcs and aapcs-vfp for windows on arm

mstorsjo created this revision. mstorsjo added reviewers: rnk, compnerd, smeenai. Herald added a subscriber: kristof.beyls. mstorsjo requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94364 Files: clang/lib/Basic/Ta