[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

MyDeveloperDay added a comment. This has been landed in the 12.0.1 RC https://github.com/llvm/llvm-project/commit/c7d7ace46258b04aa4b5df08952bfebc6fc4ce94 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/D94500

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

MyDeveloperDay added a subscriber: tstellar. MyDeveloperDay added a comment. I think we've missed the deadline for 12.0.1 which I believe was last friday. I did a practice merge and it didn't quite go in cleanly to 12.0.X branch Normally we would mark the bug in the bug tracker for the next

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj added a comment. > A crash (https://bugs.llvm.org/show_bug.cgi?id=50663) in 12.0.1 is fixed by > your changes here when merged to the 12 branch, I'm not sure if this needs to > be backported to 12 I guess it might depend on if we think it's critical > enough or if there will more 12

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

MyDeveloperDay added a comment. A crash (https://bugs.llvm.org/show_bug.cgi?id=50663) in 12.0.1 is fixed by your changes here when merged to the 12 branch, I'm not sure if this needs to be backported to 12 I guess it might depend on if we think it's critical enough or if there will more 12

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. In D94500#2605517 , @timwoj wrote: > In D94500#2605515 , > @HazardyKnusperkeks wrote: > >> In D94500#2604754 , @timwoj wrote: >> >>>

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7f9f94b2e2b: [clang-format] Rework Whitesmiths mode to use line-level values in… (authored by timwoj, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj added a comment. In D94500#2605515 , @HazardyKnusperkeks wrote: > In D94500#2604754 , @timwoj wrote: > >> Rebase onto master again > > `master` or `main`? Please rebase on `main`. That is where the pushes

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. In D94500#2604754 , @timwoj wrote: > Rebase onto master again `master` or `main`? Please rebase on `main`. That is where the pushes land. (And as far as I can see `master` hasn't been updated in quite some time.

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj updated this revision to Diff 328308. timwoj added a comment. Rebase onto master again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/D94500 Files: clang/docs/ReleaseNotes.rst

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. Could you please rebase your patch an reupload the diff, it doesn't apply anymore. (And doing it by hand is too much work for me.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj added a comment. In D94500#2594394 , @HazardyKnusperkeks wrote: > In D94500#2593229 , @timwoj wrote: > >> In D94500#2592448 , >> @HazardyKnusperkeks wrote: >> >>>

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. In D94500#2593229 , @timwoj wrote: > In D94500#2592448 , > @HazardyKnusperkeks wrote: > >> Do you need someone to push this? > > Yes I do. I don't have committer access. Please

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj added a comment. In D94500#2592448 , @HazardyKnusperkeks wrote: > Do you need someone to push this? Yes I do. I don't have committer access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. Do you need someone to push this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/D94500 ___ cfe-commits mailing list

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj updated this revision to Diff 322689. timwoj added a comment. Rebased on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/D94500 Files: clang/docs/ReleaseNotes.rst

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. Have you rebased your change? It seems that your release notes are still for LLVM 12. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj updated this revision to Diff 322477. timwoj added a comment. Added release note entry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/D94500 Files: clang/docs/ReleaseNotes.rst

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

MyDeveloperDay added a comment. My advice leave it out of the release, the next release comes round pretty quickly. This gives us 6 months of people who use the snapshots to iron out any issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj added a comment. https://bugs.llvm.org/show_bug.cgi?id=48668 already exists as a bug report linked to this review. I'm not sure "the Zeek project would like to start using this" is a good enough reason to block an LLVM release though. I'm fairly certain there aren't a whole lot of

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

curdeius added a comment. I don't think it can go into 12.x. But if you have a good reason and a related bug report you might add this bug ticket as a release blocker of https://llvm.org/PR48902. BTW, would you mind updating clang/docs/ReleaseNotes.rst? Repository: rG LLVM Github Monorepo