[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

MaskRay added a comment. Herald added a project: All. The used code sequence has 2 bugs so the output will crash. I fixed them in 7198c87f42f6c15d76b127c1c63530e9b4d5dd39 and added my notes to

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36192790d84b: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs (authored by Conanap). Repository: rG LLVM Github

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

Conanap updated this revision to Diff 327839. Conanap added a comment. Updated 2 test cases and some nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94627/new/ https://reviews.llvm.org/D94627 Files: lld/ELF/Config.h lld/ELF/Driver.cpp lld/ELF/Options.td lld/ELF/Thunks.cpp

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

amyk added a comment. Thanks for answering the questions I previously had on this patch. Comment at: lld/ELF/Driver.cpp:763 +// Parses --power10-stubs= flags, to disable or enable Power 10 +// instructions in stubs. nit: remove the space after `=` and before

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

stefanp accepted this revision as: stefanp. stefanp added a comment. This revision is now accepted and ready to land. I just have one final nit otherwise LGTM. Feel free to fix that on commit. Please wait a couple of days and see if @MaskRay has any further comments. Comment

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

Conanap updated this revision to Diff 323000. Conanap marked 6 inline comments as done. Conanap added a comment. Fixed up a few comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94627/new/ https://reviews.llvm.org/D94627 Files: lld/ELF/Config.h lld/ELF/Driver.cpp

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

stefanp added a comment. Just nits this time around. Comment at: lld/ELF/Driver.cpp:765 +// instructions in stubs. +static bool getP10StubOpt(opt::InputArgList ) { + Conanap wrote: > For this function here, I realize we can inline all the ifs into a giant >

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

Conanap added a comment. Added a note on one of the functions Comment at: lld/ELF/Driver.cpp:765 +// instructions in stubs. +static bool getP10StubOpt(opt::InputArgList ) { + For this function here, I realize we can inline all the ifs into a giant return

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

Conanap updated this revision to Diff 320865. Conanap marked 10 inline comments as done. Conanap added a comment. Addressed comments, fixed an incorrect encoding. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94627/new/ https://reviews.llvm.org/D94627 Files: lld/ELF/Config.h