[PATCH] D95970: [HIP] Allow undefined symbols

yaxunl abandoned this revision. yaxunl added a comment. In D95970#2540669 , @tra wrote: > In D95970#2540414 , @yaxunl wrote: > >> In D95970#2540303 , @tra wrote: >> >>>

[PATCH] D95970: [HIP] Allow undefined symbols

tra added a comment. In D95970#2540414 , @yaxunl wrote: > In D95970#2540303 , @tra wrote: > >> What's going to happen if you do have an undefined reference that's *not* to >> a `__managed__` variable? > > By

[PATCH] D95970: [HIP] Allow undefined symbols

yaxunl added a comment. In D95970#2540303 , @tra wrote: > What's going to happen if you do have an undefined reference that's *not* to > a `__managed__` variable? By default HIP toolchain uses -fvisibility hidden -fapply-global-visibility-to-externs

[PATCH] D95970: [HIP] Allow undefined symbols

tra added a comment. What's going to happen if you do have an undefined reference that's *not* to a `__managed__` variable? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95970/new/ https://reviews.llvm.org/D95970 ___ cfe-commits mailing

[PATCH] D95970: [HIP] Allow undefined symbols

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. HIP managed variables need to be emitted as undefined symbols since runtime needs to define them with managed memory accessible by both device and host. Let HIP toolchain allow that with lld.