[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

This revision was automatically updated to reflect the committed changes. Closed by commit rG23d65aa44631: [OpenCL] Support enum and typedef args in TableGen BIFs (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96051/new/

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:27 + // expected-error@-3 0+{{no matching function for call to 'barrier'}} + //

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

svenvh added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:27 + // expected-error@-3 0+{{no matching function for call to 'barrier'}} + // expected-error@* {{typedef type cl_mem_fence_flags not found; include the base header with

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:27 + // expected-error@-3 0+{{no matching function for call to 'barrier'}} + // expected-error@* {{typedef type cl_mem_fence_flags not found; include the base header with

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

svenvh updated this revision to Diff 323040. svenvh added a comment. Add test for new diagnostic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96051/new/ https://reviews.llvm.org/D96051 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/OpenCLBuiltins.td

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

Anastasia added a comment. The change looks good, could we test the diagnostic that is added? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96051/new/ https://reviews.llvm.org/D96051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

svenvh updated this revision to Diff 322123. svenvh added a comment. Do not assume cast to Enum/TypedefDecl is always successful. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96051/new/ https://reviews.llvm.org/D96051 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

svenvh added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:38 +typedef uint cl_mem_fence_flags; +#define CLK_GLOBAL_MEM_FENCE 0x02 + Anastasia wrote: > Should we add this conditionally if the base header is not included? > >

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:38 +typedef uint cl_mem_fence_flags; +#define CLK_GLOBAL_MEM_FENCE 0x02 + Should we add this conditionally if the base header is not included? In the subsequent

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: jfb, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add enum and typedef argument support to `-fdeclare-opencl-builtins`, which was