[PATCH] D96132: [clang-tidy] Simplify throw keyword missing check

2021-02-20 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77056fe58e83: [clang-tidy] Simplify throw keyword missing check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D96132: [clang-tidy] Simplify throw keyword missing check

2021-02-20 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-throw-keyword-missing.cpp:97-107 +template +void templ(int i) { + if (i > 0) +SomeType(); +} + void funcCallWithTempExcTest() { steveire wrote: > njames93

[PATCH] D96132: [clang-tidy] Simplify throw keyword missing check

2021-02-20 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-throw-keyword-missing.cpp:97-107 +template +void templ(int i) { + if (i > 0) +SomeType(); +} + void funcCallWithTempExcTest() { njames93 wrote: > Can I ask

[PATCH] D96132: [clang-tidy] Simplify throw keyword missing check

2021-02-20 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-throw-keyword-missing.cpp:97-107 +template +void templ(int i) { + if (i > 0) +SomeType(); +} + void funcCallWithTempExcTest() { Can I ask what the reason for

[PATCH] D96132: [clang-tidy] Simplify throw keyword missing check

2021-02-05 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo