[PATCH] D96138: [clang-tidy] Simplify delete null ptr check

This revision was automatically updated to reflect the committed changes. Closed by commit rGd20961c6575c: [clang-tidy] Simplify delete null ptr check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96138/new/

[PATCH] D96138: [clang-tidy] Simplify delete null ptr check

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96138/new/ https://reviews.llvm.org/D96138

[PATCH] D96138: [clang-tidy] Simplify delete null ptr check

steveire updated this revision to Diff 323551. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96138/new/ https://reviews.llvm.org/D96138 Files: clang-tools-extra/clang-tidy/readability/DeleteNullPointerCheck.cpp

[PATCH] D96138: [clang-tidy] Simplify delete null ptr check

njames93 added a comment. Seems that your test cases are failing on windows, I'm guessing this is a MSVC template compatibility issue. Probably need to add `-fno-delayed-template-parsing` to the clang driver args (after `-- --`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D96138: [clang-tidy] Simplify delete null ptr check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Because it no longer relies on finding implicit