[PATCH] D96196: [Sema][NFC] Create Sema::BuildImplicitCast

2021-02-08 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:1060 if (tcr != TC_Success && msg != 0) { if (SrcExpr.isInvalid()) // if conversion failed, don't report another error return; Can we ever have this case w/ the added `if

[PATCH] D96196: [Sema][NFC] Create Sema::BuildImplicitCast

2021-02-05 Thread FĂ©lix Cloutier via Phabricator via cfe-commits
fcloutier created this revision. Herald added a subscriber: jfb. Herald added a reviewer: aaron.ballman. fcloutier requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This change creates