[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b1b30cf0f7d: [clang][SVE] Dont warn on vector to sizeless builtin implicit conversion (authored by joechrisellis). Repository: rG LLVM Github

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

joechrisellis updated this revision to Diff 325749. joechrisellis marked an inline comment as done. joechrisellis added a comment. Address linter comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97053/new/ https://reviews.llvm.org/D97053

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. LGTM thanks Comment at: clang/lib/Sema/SemaChecking.cpp:12054 // Strip vector types. - if (isa(Source)) { + if (auto *SourceVT = dyn_cast(Source)) { +if

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

joechrisellis added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:12055 + if (auto *SourceVT = dyn_cast(Source)) { +if (Target->isSizelessBuiltinType()) { + auto SourceVectorKind = SourceVT->getVectorKind(); c-rhodes wrote: > I suppose

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

joechrisellis updated this revision to Diff 325461. joechrisellis marked an inline comment as done. joechrisellis added a comment. Address @c-rhodes's comment. - use `isVLSTBuiltinType` instead of `isSizelessBuiltinType`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

c-rhodes added a comment. In D97053#2575791 , @craig.topper wrote: > Is this change specific to fixed vectors declared with arm_sve_vector_bits or > any of the subclasses of VectorType? If it allows the others, how do we know > for sure that there are

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

joechrisellis updated this revision to Diff 325410. joechrisellis added a comment. Address comments. - @c-rhodes: remove test; it is probably not necessary. - @craig.topper: add better constraints for when we do/don't bail out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

craig.topper added a comment. Is this change specific to fixed vectors declared with arm_sve_vector_bits or any of the subclasses of VectorType? If it allows the others, how do we know for sure that there are enough bits in the scalable type for the fixed vector. I ask because RISCV is also

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

c-rhodes added inline comments. Comment at: clang/test/Sema/aarch64-fixed-vector-to-scalable-implicit-conversion.c:1-32 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve \ +// RUN: -msve-vector-bits=512 -Wconversion -fallow-half-arguments-and-returns \ +//

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

joechrisellis added inline comments. Comment at: clang/test/Sema/aarch64-fixed-vector-to-scalable-implicit-conversion.c:1-32 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve \ +// RUN: -msve-vector-bits=512 -Wconversion -fallow-half-arguments-and-returns

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

c-rhodes added inline comments. Comment at: clang/test/Sema/aarch64-fixed-vector-to-scalable-implicit-conversion.c:1-32 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve \ +// RUN: -msve-vector-bits=512 -Wconversion -fallow-half-arguments-and-returns \ +//

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

joechrisellis created this revision. joechrisellis added reviewers: c-rhodes, bsmith. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. joechrisellis requested review of this revision. Herald added a project: clang. Herald added a subscriber: