This revision was automatically updated to reflect the committed changes.
Closed by commit rGd412dbe38881: [clang][NFC] Extract Target and AuxTarget
creation in CompilerInstance to new… (authored by oToToT, committed by
sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
oToToT added a comment.
Since I don't have commit access currently, might @sammccall commit this for me
with `--author="Yu-Hsun Chiang "`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97493/new/
https://reviews.llvm.org/D97493
oToToT updated this revision to Diff 326581.
oToToT added a comment.
Fix typo and rename function to `createTarget`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97493/new/
https://reviews.llvm.org/D97493
Files:
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks, this looks pretty unintrusive and will save a bunch of duplication.
Comment at: clang/include/clang/Frontend/CompilerInstance.h:385
+ // Create Target and
oToToT created this revision.
oToToT added reviewers: sammccall, rsmith.
oToToT added a project: clang.
oToToT requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: cfe-commits, sstefan1.
As @sammccall mentioned in D97109
