[PATCH] D98075: [Matrix] Implement += and -= for MatrixType

This revision was automatically updated to reflect the committed changes. Closed by commit rG63851a701eac: [Matrix] Implement += and -= for MatrixType. (authored by SaurabhJha, committed by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98075: [Matrix] Implement += and -= for MatrixType

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98075/new/ https://reviews.llvm.org/D98075

[PATCH] D98075: [Matrix] Implement += and -= for MatrixType

SaurabhJha added inline comments. Comment at: clang/test/Sema/matrix-type-operators.c:22 // expected-error@-2 {{casting 'sx10x5_t *' (aka 'float __attribute__((matrix_type(10, 5)))*') to incompatible type 'float'}} + + b -= xbolva00 wrote: > +=? Right,

[PATCH] D98075: [Matrix] Implement += and -= for MatrixType

SaurabhJha updated this revision to Diff 328850. SaurabhJha added a comment. Fix mistake in Sema/matrix-type-operators.c's add test -= -> += Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98075/new/ https://reviews.llvm.org/D98075 Files:

[PATCH] D98075: [Matrix] Implement += and -= for MatrixType

xbolva00 added inline comments. Comment at: clang/test/Sema/matrix-type-operators.c:22 // expected-error@-2 {{casting 'sx10x5_t *' (aka 'float __attribute__((matrix_type(10, 5)))*') to incompatible type 'float'}} + + b -= +=? Repository: rG LLVM

[PATCH] D98075: [Matrix] Implement += and -= for MatrixType

SaurabhJha added a comment. In D98075#2609074 , @fhahn wrote: > Thanks for the patch! Could you also extend the Sema `matrix-type-operators` > tests with checks for `+=` & `-=`? > > It looks like the handling for multiply is slightly different and

[PATCH] D98075: [Matrix] Implement += and -= for MatrixType

SaurabhJha updated this revision to Diff 328849. SaurabhJha edited the summary of this revision. SaurabhJha added a comment. Implement tests for *= for matrices code gen and add tests in Sema for compound assignments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98075: [Matrix] Implement += and -= for MatrixType

fhahn added reviewers: rjmccall, erichkeane. fhahn added a comment. Thanks for the patch! Could you also extend the Sema `matrix-type-operators` tests with checks for `+=` & `-=`? It looks like the handling for multiply is slightly different and already works but is missing test coverage. It

[PATCH] D98075: [Matrix] Implement += and -= for MatrixType

SaurabhJha created this revision. Herald added a subscriber: tschuett. SaurabhJha requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98075 Files: clang/lib/Sema/SemaExpr.cpp