This revision was automatically updated to reflect the committed changes.
Closed by commit rGd4a8c7359b57: [clang] Fix ICE on invalid type parameters for
concepts (authored by mizvekov).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98095/new/
mizvekov updated this revision to Diff 329149.
mizvekov added a comment.
Addressed rsmith's concerns.
Fixed test type name to avoid picking up suggestions from other tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98095/new/
mizvekov added inline comments.
Comment at: clang/lib/Sema/SemaType.cpp:5947-5948
TL.setNameLoc(DS.getTypeSpecTypeLoc());
if (!DS.isConstrainedAuto())
return;
if (DS.getTypeSpecScope().isNotEmpty())
rsmith wrote:
> Given that we
rsmith added inline comments.
Comment at: clang/lib/Sema/SemaType.cpp:1644-1661
+TemplateIdAnnotation *TemplateId = DS.getRepAsTemplateId();
+ConceptDecl *TypeConstraintConcept = nullptr;
+llvm::SmallVector TemplateArgs;
if (DS.isConstrainedAuto()) {
-
mizvekov updated this revision to Diff 328919.
mizvekov added a comment.
Repush, no changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98095/new/
https://reviews.llvm.org/D98095
Files:
clang/lib/Sema/SemaType.cpp
mizvekov created this revision.
mizvekov requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
See PR48593.
Constraints with invalid type parameters were causing a null pointer
dereference.
Signed-off-by: Matheus Izvekov
Repository:
rG
