[PATCH] D98146: OpaquePtr: Turn inalloca into a type attribute

2021-03-29 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D98146#2654598 , @arsenm wrote: > 4fefed65637ec46c8c2edad6b07b5569ac61e9e5 > Please include the "Differential Revision: ..." line in the commit message -

[PATCH] D98146: OpaquePtr: Turn inalloca into a type attribute

2021-03-29 Thread Oliver Stannard (Linaro) via Phabricator via cfe-commits
ostannard added a comment. I've reverted this (07e46367bae ) because it was causing Bindings/Go/go.test to fail on the buoldbots. Example failure at http://lab.llvm.org:8011/#/builders/107/builds/6075. CHANGES SINCE LAST

[PATCH] D98146: OpaquePtr: Turn inalloca into a type attribute

2021-03-28 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm closed this revision. arsenm added a comment. 4fefed65637ec46c8c2edad6b07b5569ac61e9e5 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98146/new/ https://reviews.llvm.org/D98146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98146: OpaquePtr: Turn inalloca into a type attribute

2021-03-25 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This looks good from my PoV but make sure all of David's oustanding concerns are addressed. I think we hoped that the preallocated feature would have replaced inalloca before the opaque type pointer transition happened, but there's no reason to

[PATCH] D98146: OpaquePtr: Turn inalloca into a type attribute

2021-03-21 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:490 if (Type *Ty = getValueAsType()) { - raw_string_ostream OS(Result); + // FIXME: This should never be null Result += '('; dblaikie wrote: > arsenm wrote: > > dblaikie

[PATCH] D98146: OpaquePtr: Turn inalloca into a type attribute

2021-03-08 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:490 if (Type *Ty = getValueAsType()) { - raw_string_ostream OS(Result); + // FIXME: This should never be null Result += '('; arsenm wrote: > dblaikie wrote: > > Is it?

[PATCH] D98146: OpaquePtr: Turn inalloca into a type attribute

2021-03-07 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:490 if (Type *Ty = getValueAsType()) { - raw_string_ostream OS(Result); + // FIXME: This should never be null Result += '('; dblaikie wrote: > Is it? Could you replace

[PATCH] D98146: OpaquePtr: Turn inalloca into a type attribute

2021-03-07 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. > I think byval/sret and the others are close to being able to rip out the code > to support the missing type case. A lot of this code is shared with inalloca, > so catch this up to the